This repository was archived by the owner on Jan 20, 2025. It is now read-only.
translation docs/static-vs-normal-queries into Japanese #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ur1
requested review from
Naturalclar,
hirotaka,
smorimoto and
uetchy
as code owners
smorimoto
added
the
status: awaiting review
hirotaka
suggested changes
Jan 20, 2020
Contributor
hirotaka
left a comment
hirotaka
left a comment
There was a problem hiding this comment.
ありがとうございます！
わたしがまだ消化しきれていないのですが、取り急ぎ気付いた箇所だけSuggestionあげさせていただきます。
| ``` | ||
|
|
||
| In either case, you can add traced SVG support by adding `_tracedSVG` to the end of each fragment. _Note this won’t work in the GraphQL explorer._ | ||
| In either case, you can add traced SVG support by adding `_tracedSVG` to the end of each fragment. _注： this won’t work in the GraphQL explorer._ |
Contributor
There was a problem hiding this comment.
意図した修正ではないと思われるのでご確認お願いします。
Contributor
Author
There was a problem hiding this comment.
ありがとうございます。別の翻訳のページで開いていたファイルのタブで編集しちゃったみたいです
ご指摘ありがとうございます。
hirotaka
added
the
status: awaiting author response
Co-Authored-By: Hirotaka Mizutani <[email protected]>
Co-Authored-By: Hirotaka Mizutani <[email protected]>
uetchy
previously approved these changes
Jan 23, 2020
Contributor
|
@hirotaka 再レビューお願いします |
uetchy
added
status: awaiting more approval
hirotaka
suggested changes
Jan 23, 2020
Contributor
hirotaka
left a comment
hirotaka
left a comment
There was a problem hiding this comment.
一つだけ細かいのですが、Suggestionあげたのでご確認お願いいたします。
hirotaka
added
the
status: awaiting author response
Co-Authored-By: Hirotaka Mizutani <[email protected]>
Naturalclar
reviewed
Jan 25, 2020
Naturalclar
suggested changes
Jan 25, 2020
Contributor
Naturalclar
left a comment
Naturalclar
left a comment
There was a problem hiding this comment.
全体的に良いと感じました！１点 Suggest したので確認おねがいします。
Naturalclar
removed
the
status: awaiting more approval
Co-Authored-By: Jesse Katsumata <[email protected]>
Contributor
Author
|
@Naturalclar |
uetchy
added
status: awaiting review
Naturalclar
added
status: awaiting more approval
Naturalclar
approved these changes
Jan 27, 2020
uetchy
removed
the
status: awaiting more approval
uetchy
approved these changes
Jan 27, 2020
uetchy
added
status: awaiting more approval
Contributor
|
@hirotaka 再レビューお願いします |
uetchy
removed
the
status: ready to merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
docs/static-vs-normal-queriesの翻訳です。原文ページ
Static vs Normal Queries
チェックリスト
textlintを使って校正を行いました（推奨）Allow edits from maintainersにチェックを入れました。しばらく待ってもレビューが終わらなかったり、必要なレビュー数が足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。
レビューよろしくお願いします 🙇