Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@yamanoku
Copy link
Contributor

概要

https://www.gatsbyjs.org/docs/making-your-site-accessible/ の日本語翻訳対応しました。
OSS翻訳初めてなので不手際あるかもですが、レビューのほどよろしくお願いします!

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました(推奨)
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数が足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 18, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@uetchy uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 23, 2020
@yamanoku
Copy link
Contributor Author

@uetchy 確認ありがとうございます!対応しましたのでよろしくおねがいします。

@uetchy
Copy link
Contributor

uetchy commented Jan 24, 2020

@yamanoku コード差分に表示されているtextlintエラーを解消してください✍️

@yamanoku
Copy link
Contributor Author

コード差分の件気づきませんでした:pray: 報告ありがとうございます:+1:

@uetchy uetchy added status: ready to merge A pull request that can be merged once CI is green and removed status: awaiting author response A pull request that is awaiting author's response status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 24, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!ありがとうございます!

@Naturalclar Naturalclar merged commit c1f264a into gatsbyjs:master Jan 25, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 25, 2020

Holy buckets, @yamanoku — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@yamanoku yamanoku deleted the docs/making-your-site-accessible branch January 25, 2020 10:08
@uetchy uetchy removed the status: ready to merge A pull request that can be merged once CI is green label Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants