This repository was archived by the owner on Jan 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 113
translate docs/making-your-site-accessible #72
Merged
Naturalclar
merged 5 commits into
gatsbyjs:master
from
yamanoku:docs/making-your-site-accessible
Jan 25, 2020
Merged
translate docs/making-your-site-accessible #72
Naturalclar
merged 5 commits into
gatsbyjs:master
from
yamanoku:docs/making-your-site-accessible
Jan 25, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uetchy
reviewed
Jan 23, 2020
Contributor
uetchy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Contributor
Author
|
@uetchy 確認ありがとうございます!対応しましたのでよろしくおねがいします。 |
Contributor
|
@yamanoku コード差分に表示されているtextlintエラーを解消してください✍️ |
Contributor
Author
|
コード差分の件気づきませんでした:pray: 報告ありがとうございます:+1: |
uetchy
approved these changes
Jan 24, 2020
Naturalclar
approved these changes
Jan 25, 2020
Contributor
Naturalclar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!ありがとうございます!
|
Holy buckets, @yamanoku — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
https://www.gatsbyjs.org/docs/making-your-site-accessible/ の日本語翻訳対応しました。
OSS翻訳初めてなので不手際あるかもですが、レビューのほどよろしくお願いします!
チェックリスト
textlintを使って校正を行いました(推奨)Allow edits from maintainersにチェックを入れました。しばらく待ってもレビューが終わらなかったり、必要なレビュー数が足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。