Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@Shinyaigeek
Copy link
Contributor

I translated docs/using-client-side-only-packages .
Original Page: Using Client-Side Only Packages
レビューお願いします 🙏

uetchy
uetchy previously approved these changes Jan 17, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy added the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 17, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!いくつか気になった箇所をsuggestionさせていただいたので、確認お願いいたします。

@hirotaka hirotaka added the status: awaiting author response A pull request that is awaiting author's response label Jan 17, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
LGTM👍

@hirotaka hirotaka requested a review from uetchy January 17, 2020 07:08
@hirotaka hirotaka removed the status: awaiting author response A pull request that is awaiting author's response label Jan 17, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy merged commit 0664431 into gatsbyjs:master Jan 20, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 20, 2020

Holy buckets, @Shinyaigeek — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants