Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@2ur1
Copy link
Contributor

@2ur1 2ur1 commented Jan 16, 2020

Docs/starters の翻訳です。
レビューよろしくお願いします 🙇

原文ページ
Gatsby Starters

@uetchy
Copy link
Contributor

uetchy commented Jan 17, 2020

boilerplateをどう訳するか、難しいですね。

  • 定形
  • テンプレート
  • 雛形
  • ボイラープレート

雛形かボイラープレートが近い気がします。

cc @Naturalclar @imbsky @hirotaka

@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 17, 2020
@2ur1
Copy link
Contributor Author

2ur1 commented Jan 17, 2020

@uetchy
ありがとうございます!
確かにここ、どう訳すか悩んでいたのですが、日本語だと「雛形」がすごくしっくり来ます
「ボイラープレート」はわかるけれども初心者の方にはもしかしたらわかりにくいかな?と思い避けていました。
問題なさそうであれば「雛形」で進め、修正いたします

@uetchy
Copy link
Contributor

uetchy commented Jan 17, 2020

雛形で行きましょう!

@2ur1
Copy link
Contributor Author

2ur1 commented Jan 17, 2020

定型→雛形に修正いたしました!レビューよろしくおねがいいたします

uetchy
uetchy previously approved these changes Jan 17, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 17, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!Suggetionをいくつかさせていただいたのでご確認お願いいたします。

@hirotaka hirotaka added the status: awaiting author response A pull request that is awaiting author's response label Jan 18, 2020
Co-Authored-By: Hirotaka Mizutani <[email protected]>
Co-Authored-By: Hirotaka Mizutani <[email protected]>
@smorimoto smorimoto removed the status: awaiting author response A pull request that is awaiting author's response label Jan 18, 2020
@smorimoto smorimoto requested review from hirotaka and uetchy January 18, 2020 23:27
@smorimoto smorimoto added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 18, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!LGTM 👍

@smorimoto smorimoto removed the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 19, 2020
@smorimoto smorimoto added the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 19, 2020
@smorimoto smorimoto added status: ready to merge A pull request that can be merged once CI is green and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 19, 2020
@Naturalclar Naturalclar merged commit 27a27cf into gatsbyjs:master Jan 19, 2020
@uetchy uetchy removed the status: ready to merge A pull request that can be merged once CI is green label Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants