Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@hirotaka
Copy link
Contributor

いろいろと不足があると思いますが、どうぞよろしくお願いいたします🙏

@hirotaka hirotaka requested a review from Naturalclar as a code owner January 11, 2020 13:35
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全体的にかなり良いと思います!
いくつかコメントしたので確認お願いします。

あと、個人的に日本語から英語に切り替わるとき、及び英語から日本語に切り替わるときに space があったほうが読みやすそうかな?と思ったのですがどうでしょうか。

その辺は Textlint を導入すれば勝手に直してくれるかな。

uetchy
uetchy previously approved these changes Jan 12, 2020
Co-Authored-By: Jesse Katsumata <[email protected]>
hirotaka and others added 2 commits January 13, 2020 12:18
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Yasuaki Uechi <[email protected]>
@hirotaka
Copy link
Contributor Author

あと、個人的に日本語から英語に切り替わるとき、及び英語から日本語に切り替わるときに space があったほうが読みやすそうかな?と思ったのですがどうでしょうか。

spaceはあった方がいいですね。修正します。

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@uetchy uetchy merged commit bca1479 into master Jan 13, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 13, 2020

Holy buckets, @hirotaka — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants