Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@yahooshiken
Copy link
Contributor

I translated docs/using-gatsby-professionally into Japanese.
Original page: Using Gatsby Professionally | GatsbyJS

レビューよろしくお願いいたします🙇

Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@@ -1,18 +1,18 @@
---
title: Using Gatsby Professionally
title: Gatsbyを専門的に使用する
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/gatsbyjs/gatsby-ja/blob/master/docs/docs/index.md
こちらの表記「プロとして Gatsby を使う」と合わせましょう。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

該当部分を修正しました 🙇‍♂️

@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 17, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!Suggestしたのでご確認お願いいたします。

uetchy
uetchy previously approved these changes Jan 21, 2020
@uetchy uetchy removed the status: awaiting author response A pull request that is awaiting author's response label Jan 21, 2020
@yahooshiken yahooshiken requested a review from hirotaka January 22, 2020 10:11
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつか Suggest しました。ご確認おねがいします!

@Naturalclar Naturalclar added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 22, 2020
@yahooshiken
Copy link
Contributor Author

いくつか Suggest しました。ご確認おねがいします!

Suggest 確認して commit しました。ありがとうございます!

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ありがとうございます!

@Naturalclar Naturalclar removed the status: awaiting author response A pull request that is awaiting author's response label Jan 22, 2020
@Naturalclar Naturalclar added the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 22, 2020
@uetchy
Copy link
Contributor

uetchy commented Jan 23, 2020

@hirotaka 再レビューお願いします。

Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hirotaka hirotaka merged commit 905fffe into gatsbyjs:master Jan 23, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 23, 2020

Holy buckets, @yahooshiken — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants