Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@sottar
Copy link
Contributor

@sottar sottar commented Jan 16, 2020

translate docs/releases-and-migration

https://www.gatsbyjs.org/docs/releases-and-migration/

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ありがとうございます!Suggest したので確認お願いします

@sottar sottar requested a review from smorimoto as a code owner January 17, 2020 01:35
@sottar
Copy link
Contributor Author

sottar commented Jan 17, 2020

ありがとうございます!反映したので確認お願いします!

Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lintで指摘されているのを、Suggestしました。

@uetchy uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 17, 2020
@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 17, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!LGTM 👍

@uetchy uetchy requested a review from Naturalclar January 20, 2020 04:08
@uetchy uetchy added the status: ready to merge A pull request that can be merged once CI is green label Jan 20, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@Naturalclar Naturalclar merged commit c483317 into gatsbyjs:master Jan 22, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 22, 2020

Holy buckets, @sottar — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@uetchy uetchy removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned status: ready to merge A pull request that can be merged once CI is green labels Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants