Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@2ur1
Copy link
Contributor

@2ur1 2ur1 commented Jan 16, 2020

tutorial/wordpress-image-tutorialの翻訳です。
レビューよろしくお願いします 🙇

原文ページ
Adding Images to a WordPress Site

@uetchy uetchy added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 16, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRありがとうございます!
いくつか suggest したので確認お願いします。

@2ur1 2ur1 requested a review from smorimoto as a code owner January 16, 2020 21:21
@2ur1
Copy link
Contributor Author

2ur1 commented Jan 16, 2020

ご丁寧なレビューありがとうございます。
修正を取り込みコミットいたしました。

Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!いくつかコメントしたのでご確認お願いします 🙏

@hirotaka hirotaka added the status: awaiting author response A pull request that is awaiting author's response label Jan 17, 2020
@2ur1
Copy link
Contributor Author

2ur1 commented Jan 17, 2020

@hirotaka
レビューありがとうございます。Typo気づかず申し訳ありませんでした。
ご指摘頂いた部分反映いたしました。よろしくお願いいたします。

@hirotaka hirotaka self-requested a review January 17, 2020 11:28
hirotaka
hirotaka previously approved these changes Jan 17, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
LGTM 👍

Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 17, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy removed the status: awaiting author response A pull request that is awaiting author's response label Jan 17, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hirotaka hirotaka requested a review from Naturalclar January 18, 2020 05:11
@2ur1
Copy link
Contributor Author

2ur1 commented Jan 19, 2020

@Naturalclar
お手すきにchange request修正対応のご確認よろしくお願い致します。

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!LGTM!

@Naturalclar Naturalclar merged commit 3145d3f into gatsbyjs:master Jan 19, 2020
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants