Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@sasurau4
Copy link
Contributor

@sasurau4 sasurau4 commented Jan 16, 2020

Overview

part of #1

Note

ドキュメントへのリンクは翻訳された状態のものを採用するのかよく分からなかったので、とりあえず残してあります。

@uetchy uetchy added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 16, 2020
@uetchy uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 16, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻訳は全体的に良いです!半角と全角が切り替わるところにスペースを入れたいのでそこの対応をお願いします:bow:

@sasurau4 sasurau4 requested a review from smorimoto as a code owner January 17, 2020 02:02
@sasurau4 sasurau4 requested a review from Naturalclar January 17, 2020 02:02
@uetchy uetchy removed the status: awaiting author response A pull request that is awaiting author's response label Jan 17, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます。追加でいくつか Suggest したので確認おねがいしますー

@hirotaka hirotaka added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 19, 2020
@sasurau4 sasurau4 requested a review from Naturalclar January 20, 2020 16:49
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naturalclar Naturalclar removed the status: awaiting author response A pull request that is awaiting author's response label Jan 21, 2020
@smorimoto smorimoto merged commit 7713f8c into gatsbyjs:master Jan 21, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 21, 2020

Holy buckets, @sasurau4 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@sasurau4 sasurau4 deleted the translate/gatsby-cli branch January 21, 2020 07:58
@uetchy uetchy added core pages and removed core pages status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants