Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@isy
Copy link
Contributor

@isy isy commented Jan 16, 2020

レビューお願いします🙏

@uetchy uetchy added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 16, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常に読みやすいです👍

@uetchy uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 16, 2020
@isy isy requested a review from smorimoto as a code owner January 16, 2020 15:54
@isy isy requested a review from uetchy January 16, 2020 15:58
@isy
Copy link
Contributor Author

isy commented Jan 16, 2020

修正しました!👻

uetchy
uetchy previously approved these changes Jan 17, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 17, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!翻訳はとてもわかりやすかったです。
半角と全角のスペースだけいれさせていただきました。

@hirotaka hirotaka added the status: awaiting author response A pull request that is awaiting author's response label Jan 17, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/tutorial/index.md でGatsbyで固有の名称はカタカナにしていたので、修正させてもらいました。

Co-Authored-By: Hirotaka Mizutani <[email protected]>
@isy isy dismissed stale reviews from uetchy via 54b1780 January 17, 2020 09:22
@isy
Copy link
Contributor Author

isy commented Jan 17, 2020

@hirotaka
レビューありがとうございます!修正しました✍

@hirotaka hirotaka self-requested a review January 17, 2020 11:30
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
LGTM 👍

@hirotaka hirotaka requested a review from uetchy January 17, 2020 11:31
@hirotaka hirotaka removed the status: awaiting author response A pull request that is awaiting author's response label Jan 17, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy merged commit cbb4adb into gatsbyjs:master Jan 17, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 17, 2020

Holy buckets, @isy — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants