-
Notifications
You must be signed in to change notification settings - Fork 113
Translate docs/docs/themes/building-themes #47
Translate docs/docs/themes/building-themes #47
Conversation
uetchy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2回目の貢献ありがとうございます🚀
Naturalclar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR ありがとうございます! いくつか Suggest したので確認お願いします:bow:
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
|
レビュー&Suggestありがとうございました! リストの(「空の設定ファイル」で終えている箇所など)は体言止めなので句点は省略しておりましたが、メンテナーさんの感覚として不自然だったと認識して取り込んでおります。 他のSuggestについてはすべて問題なさそうで取り込んであります。 別件ですが、オートメーションのtextlintが失敗しているようです(ローカルで確認しましたが、lintは通ります)、こちらの再実行の方法がわからないのですが、ご教示頂けると助かります。 |
|
CIに関しては恐らくGitHub Actions側の障害か何かが原因なようで、リトライさせたのでもう大丈夫なはずです。 |
|
了解しました。ご対応ありがとうございました! |
uetchy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Naturalclar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!
|
Holy buckets, @yukisato — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
レビューをよろしくお願い致します。