Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@yukisato
Copy link
Contributor

レビューをよろしくお願い致します。

@uetchy uetchy added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 16, 2020
uetchy
uetchy previously approved these changes Jan 16, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2回目の貢献ありがとうございます🚀

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 16, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ありがとうございます! いくつか Suggest したので確認お願いします:bow:

@yukisato
Copy link
Contributor Author

レビュー&Suggestありがとうございました!

リストの(「空の設定ファイル」で終えている箇所など)は体言止めなので句点は省略しておりましたが、メンテナーさんの感覚として不自然だったと認識して取り込んでおります。

他のSuggestについてはすべて問題なさそうで取り込んであります。

別件ですが、オートメーションのtextlintが失敗しているようです(ローカルで確認しましたが、lintは通ります)、こちらの再実行の方法がわからないのですが、ご教示頂けると助かります。

@smorimoto
Copy link
Contributor

CIに関しては恐らくGitHub Actions側の障害か何かが原因なようで、リトライさせたのでもう大丈夫なはずです。

@yukisato
Copy link
Contributor Author

了解しました。ご対応ありがとうございました!

@yukisato yukisato requested a review from Naturalclar January 16, 2020 23:17
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@Naturalclar Naturalclar merged commit 564b5cd into gatsbyjs:master Jan 22, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 22, 2020

Holy buckets, @yukisato — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@yukisato yukisato deleted the docs/themes/building-themes branch January 23, 2020 18:25
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants