Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@ryo4004
Copy link
Contributor

@ryo4004 ryo4004 commented Jan 16, 2020

I translated docs/sass into Japanese.
Original page: docs/sass

@uetchy uetchy added status: awaiting review A pull request that is currently awaiting a reviewer's response status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 16, 2020
uetchy
uetchy previously approved these changes Jan 16, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@uetchy uetchy removed the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 16, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ありがとうございます!他の翻訳との統一性を保つためにいくつか suggest しました。確認おねがいします!

@uetchy uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 16, 2020
uetchy
uetchy previously approved these changes Jan 17, 2020
@uetchy uetchy removed the status: awaiting author response A pull request that is awaiting author's response label Jan 17, 2020
smorimoto
smorimoto previously approved these changes Jan 19, 2020
@ryo4004
Copy link
Contributor Author

ryo4004 commented Jan 19, 2020

@imbsky
レビューありがとうございます。
ご指摘いただいた部分を修正いたしました。
よろしくお願いします。

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ありがとうございます!

@smorimoto smorimoto removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 19, 2020
@smorimoto smorimoto added the status: ready to merge A pull request that can be merged once CI is green label Jan 19, 2020
@smorimoto
Copy link
Contributor

@ryo4004 良さそうです、ありがとうございます。

@smorimoto smorimoto merged commit ef1d5c7 into gatsbyjs:master Jan 19, 2020
@ryo4004 ryo4004 deleted the translate branch January 25, 2020 04:37
@uetchy uetchy removed the status: ready to merge A pull request that can be merged once CI is green label Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants