Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@kaisugi
Copy link
Contributor

@kaisugi kaisugi commented Jan 16, 2020

レビューお願いいたします 🙇

uetchy
uetchy previously approved these changes Jan 16, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response status: awaiting review A pull request that is currently awaiting a reviewer's response status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 16, 2020
@kaisugi
Copy link
Contributor Author

kaisugi commented Jan 16, 2020

修正しました 👍

Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy removed status: awaiting author response A pull request that is awaiting author's response status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 16, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常に良い翻訳と思いました!
関係ないけど、このページ、Mac 以外のユーザに優しくなさそう‥
原文に Windows と Linux の場合の対応を追加する PR とか出してもいいかも

@Naturalclar Naturalclar merged commit aa884f2 into gatsbyjs:master Jan 16, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 16, 2020

Holy buckets, @7ma7X — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants