Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

additional-tutorial first commit #30

Merged
merged 3 commits into from
Jan 16, 2020
Merged

additional-tutorial first commit #30

merged 3 commits into from
Jan 16, 2020

Conversation

@n-harada
Copy link
Contributor

@n-harada n-harada commented Jan 15, 2020

I translated tutorial/additional-tutorials into Japanese.
If there is no problem, please merge this.

uetchy
uetchy reviewed Jan 15, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/tutorial/additional-tutorials.md Outdated
There are many use cases for Gatsby, from the very common "happy paths" to more specific and complex integrations. With additional Gatsby tutorials, learn about more topics that go beyond [the basics](/tutorial/) and gain development superpowers.
## 追加のチュートリアル

Gatsby には、よくある「ハッピーパス」のようなものから、固有で複合的な使われ方まで、多くのユースケースがあります。追加のチュートリアルによって、[基本](/tutorial/)のその先を学び、開発力を上げましょう。
Copy link
Contributor

@uetchy uetchy Jan 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ハッピーパス: 気の利いた訳語のアイディアはありませんか？

happy path: A default scenario in which no exceptional or error conditions arise.

「幸せな道程」は直訳すぎるし...

Copy link
Contributor Author

@n-harada n-harada Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

まだ全然浸透してない言葉ですもんね
かなり意訳になってしまいますが、
よくある「ハッピーパス」のようなものから→すでに動作が保証されている使い方から
はどうでしょうか

Copy link
Contributor Author

@n-harada n-harada Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

追記
そうしましたら、「固有で複合的な使われ方」の方も「固有で複合的な使い方」にした方がベターですね

Copy link
Contributor

@uetchy uetchy Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すでに動作が保証されている使い方

すごく良いです！無理に単語として扱うのではない、文脈にあった訳し方だと思います。

Copy link
Contributor Author

@n-harada n-harada Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良かったです！レビューありがとうございます！

@gatsbybot gatsbybot mentioned this pull request Jan 15, 2020
Closed
uetchy
uetchy previously approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます🎉

Naturalclar
Naturalclar reviewed Jan 15, 2020
View reviewed changes
docs/tutorial/additional-tutorials.md Outdated
---

There are many use cases for Gatsby, from the very common "happy paths" to more specific and complex integrations. With additional Gatsby tutorials, learn about more topics that go beyond [the basics](/tutorial/) and gain development superpowers.
## 追加のチュートリアル
Copy link
Contributor

@Naturalclar Naturalclar Jan 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

見やすさの為に善意でやっていることを承知の上で、基本的に原文に無い部分は追加しなくても大丈夫です！
原文と改行をあわせていただけると助かります:bow:

Copy link
Contributor Author

@n-harada n-harada Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ごめんなさい、ミスで余計なのも入れていました
修正しました！

Naturalclar
Naturalclar suggested changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文章の位置を原文と合わせていただけると助かります:pray:

@uetchy uetchy added status: awaiting review A pull request that is currently awaiting a reviewer's response status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 16, 2020
Naturalclar
Naturalclar approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！ LGTM

@Naturalclar Naturalclar merged commit 8566e70 into gatsbyjs:master Jan 16, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 16, 2020

Holy buckets, @n-harada — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hirotaka hirotaka Awaiting requested review from hirotaka

2 more reviewers

@uetchy uetchy uetchy approved these changes

@Naturalclar Naturalclar Naturalclar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@n-harada @uetchy @Naturalclar