Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@dragoneena12
Copy link
Contributor

概要

docs/browser-support.md を翻訳しました。

チェック一覧

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

Ref: #1

uetchy
uetchy previously approved these changes Jun 17, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@uetchy uetchy added status: ready to merge A pull request that can be merged once CI is green status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jun 17, 2020
@smorimoto
Copy link
Contributor

smorimoto commented Jun 17, 2020

Oxford dash doesn’t exist in Japanese, and it should be changed to a more natural style.

@dragoneena12
Copy link
Contributor Author

Thank you for reviewing!
I cannot find the best way to change dash expression. Could you tell me some proposal? Or is it appropriate to write like following?

[この記事](https://css-tricks.com/browserlist-good-idea/)は Browserslist を取り巻くツールに関する成長中のコミュニティーへの良い導入です。

@smorimoto
Copy link
Contributor

smorimoto commented Jun 17, 2020

Perhaps the following style is also fine.

この記事は Browserslist を取り巻くツールに関する成長中のコミュニティーへの良い導入です: https://css-tricks.com/browserlist-good-idea/

I think my proposed style is closer to the nuances of the English one, what do you think?

@dragoneena12
Copy link
Contributor Author

dragoneena12 commented Jun 18, 2020

I think your proposal is fine too. I applied your style. Could I get code review again?

@smorimoto smorimoto requested a review from uetchy June 19, 2020 06:35
@uetchy uetchy merged commit adf68d6 into gatsbyjs:master Jun 19, 2020
@gatsbot
Copy link

gatsbot bot commented Jun 19, 2020

Holy buckets, @dragoneena12 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@dragoneena12 dragoneena12 deleted the translate-browser-support branch June 19, 2020 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned status: ready to merge A pull request that can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants