This repository was archived by the owner on Jan 20, 2025. It is now read-only.
(sync) Sync with gatsby-i18n-source @ 8ff6bb0 #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a plugin guide. (#21221) * Started work on Maintaining plugin stub * Corrected Comments that were casuing .md file form showiing in preview * added Handling patches and improvments, Updating Readme and use case sections * aAdded Tooling and dependency improvements section * updated doc to fit style guide. * Updated PR with correction from Kyle G. * Updated PR with review * Updated PR with review * Updated PR with reviews * update doc with review and remove asterisk from doc-liink yaml * add reviews from Laurie * Update * update maintianing Plugin PR with reviews from Marcy Co-authored-by: GatsbyJS Bot <[email protected]>
…n/style-guide.md (#21570) * Update style-guide.md * Update style-guide.md * chore: format Co-authored-by: GatsbyJS Bot <[email protected]>
…pply redirects (#21606)
…so be in context (#21639)
…ordpress tutorial (#20931) * chore: fix doc typo in wordpress tutorial * Update docs/tutorial/wordpress-image-tutorial.md Co-authored-by: LB <[email protected]> Co-authored-by: GatsbyJS Bot <[email protected]>
… indentation (#21687)
…g session (#21603) Co-authored-by: GatsbyJS Bot <[email protected]>
… playground (#21703)
… fix notes failing tests (#21709)
…pe for using FontAwesome (#21275) * Recipe for using fontawesome * Update docs/docs/recipes/styling-css.md Co-Authored-By: Marcy Sutton <[email protected]> * Update docs/docs/recipes/styling-css.md Co-Authored-By: Marcy Sutton <[email protected]> * Update docs/docs/recipes/styling-css.md Co-Authored-By: Marcy Sutton <[email protected]> * Update docs/docs/recipes/styling-css.md Co-Authored-By: Marcy Sutton <[email protected]> * Update docs/docs/recipes/styling-css.md Co-Authored-By: Marcy Sutton <[email protected]> * Address review comments * Break FontAwesome into two words Co-authored-by: Marcy Sutton <[email protected]> Co-authored-by: Aisha Blake <[email protected]> Co-authored-by: GatsbyJS Bot <[email protected]>
…e way we determine locales (#21539) * Change the way we determine locales * update README * update with link * update * fix
… highlight (#21722) * docs: add missing syntax highlight * docs: add title to json example * Apply suggestions from code review Co-Authored-By: LB <[email protected]> Co-authored-by: LB <[email protected]>
…for using WooCommerce (#21745) * Add WooCommerce guide draft * Add WC details * chore: format * Apply suggestions from code review Co-Authored-By: LB <[email protected]> * Remove "straightforward" sentence * Reorder sections Co-authored-by: GatsbyJS Bot <[email protected]> Co-authored-by: LB <[email protected]>
…own article. (#21587) * docs/glossary: Add Markdown article. Updated sidebar, glossary.md with links to new entry. * Add a Markdown example. * Add a Markdown example. * Remove a stray < from the code example. * Typo fixes, swap caption for figcaption * switch in to from * chore: format Co-authored-by: Aisha Blake <[email protected]> Co-authored-by: GatsbyJS Bot <[email protected]>
…sby-starter-redux-storybook (#21764) I had to close my former PR because it orphaned
…sby starter #21720 (#21724) * broken link * chnge_link * link footnote * rm * chore: format Co-authored-by: GatsbyJS Bot <[email protected]>
…example site on plugin options (#21708) * add example for plugin options and a new guide on them * add example site to guides resources * Apply suggestions from code review Co-Authored-By: LB <[email protected]> * hopefully fix linting errors * Apply suggestions from code review Co-Authored-By: LB <[email protected]> Co-authored-by: LB <[email protected]>
… site generator (#21784)
…x example to example sites (#21735) * initialise using mdx example * Setup querys for MDX and create a post.md * Update MDX to redender from page directory * Update the chart-info with more graph examples * Update README.md with section on react chart * fix typo in README * update doc with review and delete unneeded files * Link MDX example to mdx/importing-and-using-components for discoverability
…ntax highlight language (#21810)
…mdx for formatting docs using pretti… (#21671)
…entry. (#21770) * docs/glossary: Adds MDX entry. Also updates glossary.md, doc-links.yaml with links to MDX article. * Capitalize MDX * Prefer you as the pronoun Co-authored-by: Aisha Blake <[email protected]>
…r ignore comment causing MDX parsing e… (#21832)
…ntributing section (#21806) * reorganize contributing section * docs and blog components * Update www/redirects.yaml Co-Authored-By: Michael <[email protected]> Co-authored-by: Michael <[email protected]> Co-authored-by: GatsbyJS Bot <[email protected]>
…graphql fragments in GraphQL API (#21811) * Remove jsdoc for graphql fragments * remove docstaticqueries * Update packages/gatsby-image/README.md Co-Authored-By: Kyle Gill <[email protected]> Co-authored-by: Kyle Gill <[email protected]> Co-authored-by: GatsbyJS Bot <[email protected]>
…ew mdx screencasts (#21781)
…nks (#21888) * fix * fix * fix
… of "CSS" (#21874)
…code exmaple with explicit require (#21830) * docs(api-proxy): update code exmaple with explicit require http-proxy-middleware v1.0.0 introduces breaking change. require/import of http-proxy-middleware is now explicit. * docs(api-proxy): update code exmaples with explicit require with comments that explains how to use the previous version * chore: format Co-authored-by: GatsbyJS Bot <[email protected]>
…se.md): add firebase.json cache configuration (#21897) * docs(deploying-to-firebase.md): add firebase.json cache configuration Adds how to update the `firebase.json` to configure the firebase cache correctly. * chore: format Co-authored-by: GatsbyJS Bot <[email protected]>
…567) The service is shutting down and should no longer be recommended - https://just-comments.com/blog/2020-03-06-just-comments-is-shutting-down.html
… (#22569) Co-authored-by: Laurie Barth <[email protected]>
… example a bit (#21971) * [docs][tutorial] Improve example a bit * [docs][tutorial] Apply requested changes Co-authored-by: gatsbybot <[email protected]>
…orage (redux) - expand stub (#21689) * docs(internals): expand stub - data storage (redux) * Apply suggestions from code review - grammar/typo fixes - make action journey header a sub of actions Co-Authored-By: LB <[email protected]> * Update docs/docs/data-storage-redux.md Co-Authored-By: LB <[email protected]> * Apply suggestions from code review Co-Authored-By: Marcy Sutton <[email protected]> * expand and re-organize namespace list * remove specific code links from action journey * change github links to master from commit, folders and index files will hopefully be quite static * bold bullets, consolidate action repetition * Apply suggestions from code review Co-Authored-By: Marcy Sutton <[email protected]> Co-authored-by: LB <[email protected]> Co-authored-by: Marcy Sutton <[email protected]> Co-authored-by: gatsbybot <[email protected]>
…- Reword redux section for actions emphasis (#21688) * docs: reword redux section in magic for actions emphasis over app use * Change href to relative path Co-Authored-By: LB <[email protected]> * move Redux Gatsby integration guide to new section in App ref guide * Update docs/docs/adding-redux-store.md Co-Authored-By: Marcy Sutton <[email protected]> * add Redux magic introduction, tweak action chat wording for readability * add redux store link into redux magic section, take out of app ref guide * fix for relative docs paths * fix: apply pronoun updates from code review Co-authored-by: LB <[email protected]> Co-authored-by: Marcy Sutton <[email protected]> Co-authored-by: gatsbybot <[email protected]>
…plate (#22572) * Add ./cache to cache paths for gitlab-ci template * Add public cache
…es for "Building a generic plugin" and link "Files gatsby looks for in plugin" closes #20527 (#21961) * Add more info to files-gatsby-looks-for-in-a-plugin * Updated links * seperate concerns for creating generic pluggin and files gatsby looks for. * added files gatsby looks for .. back into sidebars * fix doc with ref to reviews * update routing * Add reviews to PR * Remove passsive voice * Add context on what is meant by a generic plugin * Update docs/docs/creating-a-generic-plugin.md * Update docs/docs/creating-a-generic-plugin.md * Update docs/docs/creating-a-generic-plugin.md Co-authored-by: gatsbybot <[email protected]> Co-authored-by: LB <[email protected]>
…605) glossay to glossary in a code block
…g article. (#22592) * Add Server-Side Rendering article. doc-links.yaml, docs/glossary.md: Link to server-side rendering entry. * Update docs/docs/glossary/server-side-rendering.md Clarify that Gatsby is using server-side rendering APIs to create static HTML. Co-Authored-By: Aisha Blake <[email protected]> * Update docs/docs/glossary/server-side-rendering.md Change language type from SQL to HTML. Co-Authored-By: Aisha Blake <[email protected]> * Update docs/docs/glossary/server-side-rendering.md Remove an extraneous comma. Co-Authored-By: Aisha Blake <[email protected]> * chore: format Co-authored-by: Aisha Blake <[email protected]> Co-authored-by: gatsbybot <[email protected]>
…rce consistent across .org (#22566) * Make spelling of e-commerce consistent across .org * Update docs/blog/2019-03-26-what-the-jamstack-means-for-marketing/index.md Co-Authored-By: Aisha Blake <[email protected]> * Update docs/blog/2019-08-14-strivectin-case-study/index.md Co-Authored-By: Aisha Blake <[email protected]> * Update docs/blog/2019-06-19-how-the-couch-builds-websites-in-half-the-time-with-gatsby/index.md Co-Authored-By: Aisha Blake <[email protected]> * Update docs/blog/2019-06-25-profitable-agency-wordpress/index.md Co-Authored-By: Aisha Blake <[email protected]> * Update docs/blog/2019-06-25-profitable-agency-wordpress/index.md Co-Authored-By: Aisha Blake <[email protected]> * Update docs/blog/2019-05-15-enterprise-gatsby-how-to-reduce-your-digital-total-cost-of-ownership-with-gatsby/index.md Co-Authored-By: Aisha Blake <[email protected]> * Update docs/blog/2019-02-05-hapticmedia-case-study/index.md Co-Authored-By: Aisha Blake <[email protected]> * Update docs/blog/2019-06-25-profitable-agency-wordpress/index.md Co-Authored-By: Aisha Blake <[email protected]> * Update docs/blog/2019-03-07-sell-gatsby-to-clients/index.md Co-Authored-By: Aisha Blake <[email protected]> * Update docs/blog/2019-02-27-reactiflux-q-and-a/index.md Co-Authored-By: Aisha Blake <[email protected]> * Update docs/blog/2019-02-27-reactiflux-q-and-a/index.md Co-Authored-By: Aisha Blake <[email protected]> * Update docs/blog/2019-08-14-strivectin-case-study/index.md Co-Authored-By: Aisha Blake <[email protected]> * Update docs/blog/2019-06-10-how-to-recognize-when-gatsby-is-a-good-fit-for-your-client/index.md Co-Authored-By: Aisha Blake <[email protected]> * Update docs/blog/2019-06-25-profitable-agency-wordpress/index.md Co-Authored-By: Aisha Blake <[email protected]> * fix capitlization * fix tag for danger bot * Apply suggestions from code review Co-authored-by: gatsbybot <[email protected]> Co-authored-by: Aisha Blake <[email protected]>
… into sync-8ff6bb0 # Conflicts: # docs/tutorial/theme-tutorials.md
gatsbybot
requested review from
Naturalclar,
hirotaka,
smorimoto and
uetchy
as code owners
45 tasks
gatsbybot
added
the
sync
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| When identifying a topic, start by: | ||
|
|
||
| 1. Looking at GitHub issues. Good labels to seek out are [`help wanted`](https://github.com/gatsbyjs/gatsby/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22+) and [`good first issue`](https://github.com/gatsbyjs/gatsby/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22). |
There was a problem hiding this comment.
[textlint] reported by reviewdog 🐶
issue => Issue (prh)
|
|
||
| 1. Looking at GitHub issues. Good labels to seek out are [`help wanted`](https://github.com/gatsbyjs/gatsby/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22+) and [`good first issue`](https://github.com/gatsbyjs/gatsby/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22). | ||
|
|
||
| - This part may be covered if a docs issue is assigned to you, or if you’re signing up voluntarily to take on an issue. |
There was a problem hiding this comment.
[textlint] reported by reviewdog 🐶
issue => Issue (prh)
|
|
||
| 1. Looking at GitHub issues. Good labels to seek out are [`help wanted`](https://github.com/gatsbyjs/gatsby/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22+) and [`good first issue`](https://github.com/gatsbyjs/gatsby/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22). | ||
|
|
||
| - This part may be covered if a docs issue is assigned to you, or if you’re signing up voluntarily to take on an issue. |
There was a problem hiding this comment.
[textlint] reported by reviewdog 🐶
issue => Issue (prh)
| ## Selecting the correct format | ||
|
|
||
| A GitHub issue for new learning material should indicate the format. Is it a Reference or Conceptual Guide? A Tutorial? A recipe? |
There was a problem hiding this comment.
[textlint] reported by reviewdog 🐶
issue => Issue (prh)
|
|
||
| Here are some tips for gathering information on a given topic within Gatsby: | ||
|
|
||
| 1. As you prepare a contribution that adds documentation information, carefully read the accompanying GitHub issue for tips and relevant materials, and ask questions there. |
There was a problem hiding this comment.
[textlint] reported by reviewdog 🐶
issue => Issue (prh)
|
|
||
| In creating plugins, the bulk of the work is during the development phase. However, there’s still a need to take a look at the dependencies and security features from time to time. Keeping plugins up to date can become really tasking and it is important to be careful when updating dependencies, seeing as this could potentially break users' apps. | ||
|
|
||
| However, the consequences of not updating and maintaining a plugin can introduce security issues to your users. The following are some recommendations for maintaining plugins: |
There was a problem hiding this comment.
[textlint] reported by reviewdog 🐶
issue => Issue (prh)
| title: Experimental Page Build Optimizations for Incremental Data Changes | ||
| --- | ||
|
|
||
| Building sites with large amounts of content (10,000s nodes upwards) is relatively fast with Gatsby. However, some projects might start to experience issues when adopting CI/CD principles - continuously building and deploying. Gatsby rebuilds the complete app on each `gatsby build` which means the complete app also needs to be deployed. Doing this each time a small data change occurs unnecessarily increases demand on CPU, memory, and bandwidth. |
There was a problem hiding this comment.
[textlint] reported by reviewdog 🐶
issue => Issue (prh)
|
|
||
| #### Versioning | ||
|
|
||
| Starters can still be versioned inside of a repository so that you can track issues or bugs associated with specific updates, but they aren't formally released and published, so they aren't versioned like a plugin or theme is. |
There was a problem hiding this comment.
[textlint] reported by reviewdog 🐶
issue => Issue (prh)
| title: Profiling Site Performance with React Profiler | ||
| --- | ||
|
|
||
| React profiling captures timing information that can help identify performance issues within your gatsby site. |
There was a problem hiding this comment.
[textlint] reported by reviewdog 🐶
issue => Issue (prh)
|
|
||
| Although Profiler is a light-weight component, it should be used only when necessary; each use adds some CPU and memory overhead to an application. | ||
|
|
||
| A warning will be issued in a Gatsby Production build if the `--profile` option is provided. |
There was a problem hiding this comment.
[textlint] reported by reviewdog 🐶
issue => Issue (prh)
Naturalclar
added
the
status: awaiting more approval
uetchy
previously approved these changes
Mar 31, 2020
uetchy
approved these changes
Apr 1, 2020
smorimoto
approved these changes
Apr 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync all non-conflicting files with the source repo. This PR contains all updates that do not cause any conflicts and can be merged immediately.
NOTE: Do NOT squash-merge this pull request. The sync script requires a ref to the source repo in order to work correctly.