Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@Sliip831143
Copy link
Contributor

概要

docs/custom-html.md を翻訳しました。
お手数おかけしますが、ご確認よろしくお願いいたします。

チェック一覧

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

34行目「〜を持つ div を必要とします。」ですが、「〜を持つ div が必要です。」としたかった所 linter の接続詞の連続チェックに引っ掛かり、良い言い換えが思い付かずくどい言い回しとなってしまいました。もし宜しければ、恐縮ですがフォローいただければと思います。

Ref: #1

@Sliip831143 Sliip831143 changed the title Update docs/docs/custom-html.md Translate docs/docs/custom-html.md Mar 16, 2020
@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Mar 16, 2020
smorimoto
smorimoto previously approved these changes Mar 16, 2020
@smorimoto smorimoto added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Mar 16, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ありがとうございます!

@smorimoto smorimoto merged commit 6a34b74 into gatsbyjs:master Mar 16, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 16, 2020

Holy buckets, @Sliip831143 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@smorimoto
Copy link
Contributor

Thanks @Sliip831143!

@Sliip831143
Copy link
Contributor Author

当方の力不足で修正のお手数おかけしてしまい申し訳ございません!
早速のご対応誠にありがとうございました!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants