Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

translate docs/adding-comments #217

Merged
merged 4 commits into from
Mar 9, 2020
Merged

translate docs/adding-comments #217

merged 4 commits into from
Mar 9, 2020

Conversation

@taka-take
Copy link
Contributor

@taka-take taka-take commented Mar 4, 2020

概要

https://www.gatsbyjs.org/docs/adding-comments/ の日本語翻訳対応しました。
遅くなってごめんなさい！

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

Ref: #1

uetchy
uetchy previously approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！

@uetchy uetchy added the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Mar 4, 2020
Naturalclar
Naturalclar reviewed Mar 6, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Mar 6, 2020
View reviewed changes
@Naturalclar
Apply suggestions from code review
c5e74a4 
Co-Authored-By: Jesse Katsumata <[email protected]>
Naturalclar
Naturalclar reviewed Mar 6, 2020
View reviewed changes
@smorimoto smorimoto added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Mar 6, 2020
@smorimoto smorimoto requested review from Naturalclar and uetchy March 6, 2020 09:22
@Naturalclar
Update docs/docs/adding-comments.md
d4fcf9b 
Co-Authored-By: Jesse Katsumata <[email protected]>
Naturalclar
Naturalclar reviewed Mar 6, 2020
View reviewed changes
Naturalclar
Naturalclar approved these changes Mar 8, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！！

@Naturalclar Naturalclar added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Mar 8, 2020
@uetchy uetchy added status: ready to merge A pull request that can be merged once CI is green and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Mar 8, 2020
@smorimoto smorimoto merged commit 298cdaf into gatsbyjs:master Mar 9, 2020
@gatsbybot gatsbybot mentioned this pull request Mar 9, 2020
Closed
@smorimoto
Copy link
Contributor

smorimoto commented Mar 9, 2020

Thanks @taka-take!

@taka-take taka-take deleted the docs/adding-comments branch March 10, 2020 05:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hirotaka hirotaka Awaiting requested review from hirotaka

@smorimoto smorimoto Awaiting requested review from smorimoto

2 more reviewers

@uetchy uetchy uetchy approved these changes

@Naturalclar Naturalclar Naturalclar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge A pull request that can be merged once CI is green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@taka-take @smorimoto @uetchy @Naturalclar