Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@kawamataryo
Copy link
Contributor

@kawamataryo kawamataryo commented Feb 24, 2020

概要

docs/docs/adding-pagination を翻訳しました。

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

Ref: #1

@smorimoto
Copy link
Contributor

Could you please resolve the conflict first?

@smorimoto smorimoto added status: awaiting author response A pull request that is awaiting author's response status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 24, 2020
@kawamataryo kawamataryo force-pushed the docs/docs/adding-pagination branch from a869413 to dc75889 Compare February 24, 2020 07:29
@kawamataryo
Copy link
Contributor Author

@imbsky

Sorry, I fixed conflict.

@smorimoto smorimoto removed the status: awaiting author response A pull request that is awaiting author's response label Feb 24, 2020
@smorimoto
Copy link
Contributor

The quality of the translation is pretty good, so we will not have to fix the translation itself. I have added suggestions for fixing some minor mistakes, so please check 🙂

@smorimoto smorimoto added the status: awaiting author response A pull request that is awaiting author's response label Feb 24, 2020
@smorimoto smorimoto removed the status: awaiting author response A pull request that is awaiting author's response label Feb 24, 2020
@smorimoto smorimoto added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 24, 2020
@kawamataryo
Copy link
Contributor Author

@imbsky

Thanks for the feedback !!
I accepted your suggestion.

@smorimoto
Copy link
Contributor

Looks good overall. Approved, thanks for your contribution.

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@Naturalclar Naturalclar merged commit 156c9ce into gatsbyjs:master Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants