-
Notifications
You must be signed in to change notification settings - Fork 113
translate docs/global-css #167
Conversation
2ebf7a2 to
0d90510
Compare
uetchy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
とても良い翻訳です!
Co-Authored-By: Yasuaki Uechi <[email protected]>
Co-Authored-By: Yasuaki Uechi <[email protected]>
Co-Authored-By: Yasuaki Uechi <[email protected]>
Co-Authored-By: Yasuaki Uechi <[email protected]>
|
@uetchy Suggestion を取り込みました |
uetchy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Naturalclar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR ありがとうございます!いくつか Suggest したので確認おねがいします。
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
|
@Naturalclar Suggestion全て取り込みました!レビューありがとうございます。 |
Naturalclar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!LGTM!
|
Holy buckets, @harapeko — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
概要
https://www.gatsbyjs.org/docs/global-css/ の翻訳です
チェックリスト
textlintを使って校正を行いました。Allow edits from maintainersにチェックを入れました。補足
shared layoutを共通レイアウトコンポーネント、共有レイアウトコンポーネントどちらで訳すか?迷いましたが前者にしました。
/tutorial/part-two/、/tutorial/part-three/は後者を採用しています。統一したいので正解の提示を希望します。
従来の CSS (非 CSS-in-JS)を使用している場合と訳した中で原文にはない(非 CSS-in-JS)という補足を追加しています。これは日本語で「従来のCSS」ですと、どんなCSSを指しているか分かりづらいと感じた為です。文脈から対象キーワードを拾った形になります。
https://github.com/gatsbyjs/gatsby-ja/pull/167/files#diff-91f91eed919ca0e6b0d41e00f4683760R111
問題がないかご確認おねがいします。
Ref: #1