Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@harapeko
Copy link
Contributor

@harapeko harapeko commented Feb 9, 2020

概要

https://www.gatsbyjs.org/docs/global-css/ の翻訳です

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

  • shared layout を共通レイアウトコンポーネント、共有レイアウトコンポーネントどちらで訳すか?
    迷いましたが前者にしました。
    /tutorial/part-two//tutorial/part-three/ は後者を採用しています。
    統一したいので正解の提示を希望します。
  • 従来の CSS (非 CSS-in-JS)を使用している場合 と訳した中で原文にはない (非 CSS-in-JS) という補足を追加しています。
    これは日本語で「従来のCSS」ですと、どんなCSSを指しているか分かりづらいと感じた為です。文脈から対象キーワードを拾った形になります。
    https://github.com/gatsbyjs/gatsby-ja/pull/167/files#diff-91f91eed919ca0e6b0d41e00f4683760R111
    問題がないかご確認おねがいします。

Ref: #1

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Feb 9, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とても良い翻訳です!

@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 10, 2020
harapeko and others added 4 commits February 10, 2020 23:04
@harapeko
Copy link
Contributor Author

@uetchy Suggestion を取り込みました

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 10, 2020
uetchy
uetchy previously approved these changes Feb 10, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@smorimoto smorimoto added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Feb 11, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ありがとうございます!いくつか Suggest したので確認おねがいします。

Co-Authored-By: Jesse Katsumata <[email protected]>
harapeko and others added 6 commits February 11, 2020 21:53
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
@harapeko
Copy link
Contributor Author

@Naturalclar Suggestion全て取り込みました!レビューありがとうございます。

@Naturalclar Naturalclar added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 11, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!LGTM!

@uetchy uetchy merged commit 9828b0f into gatsbyjs:master Feb 11, 2020
@gatsbot
Copy link

gatsbot bot commented Feb 11, 2020

Holy buckets, @harapeko — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@harapeko harapeko self-assigned this Feb 13, 2020
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants