Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@gentksb
Copy link
Contributor

@gentksb gentksb commented Feb 7, 2020

概要

docs/deploying-to-netlify を翻訳しました。

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

none

Ref: #1

@gentksb gentksb force-pushed the docs/deploying-to-netlify branch from 868515a to 5520eec Compare February 7, 2020 10:26
@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Feb 7, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
他とフォーマットをあわせるため、全体的に句読点などの前後にはスペースを入れないようにしているので、そのあたりをSuggestionさせていただきました。ご確認お願いいたします。

@hirotaka hirotaka added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 8, 2020
@gentksb gentksb requested a review from hirotaka February 8, 2020 13:07
@gentksb
Copy link
Contributor Author

gentksb commented Feb 8, 2020

Suggestion内容を全て反映しました 😃

@smorimoto smorimoto added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 9, 2020
Naturalclar
Naturalclar previously approved these changes Feb 9, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Naturalclar Naturalclar added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 9, 2020
@smorimoto smorimoto added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Feb 9, 2020
@gentksb
Copy link
Contributor Author

gentksb commented Feb 10, 2020

@imbsky suggestionを反映しました 👍

Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

追加でいくつか Suggestion させていたので、ご確認お願いいたします。

@gentksb
Copy link
Contributor Author

gentksb commented Feb 10, 2020

Suggestionの取り込みとLint修正を実施しました

Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 10, 2020
@gentksb gentksb requested a review from hirotaka February 10, 2020 07:25
@hirotaka hirotaka removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Feb 10, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@hirotaka hirotaka merged commit f5fb6a1 into gatsbyjs:master Feb 10, 2020
@gatsbot
Copy link

gatsbot bot commented Feb 10, 2020

Holy buckets, @gentksb — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@gentksb gentksb deleted the docs/deploying-to-netlify branch February 10, 2020 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants