Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@mqtsuo02
Copy link
Contributor

@mqtsuo02 mqtsuo02 commented Feb 6, 2020

概要

docs/deploying-to-firebase を翻訳しました。
レビューよろしくお願いします。

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

Ref: #1

@uetchy uetchy added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Feb 6, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!一点だけSuggestionしたので、ご確認いただきますようお願いいたします。

@hirotaka hirotaka added the status: awaiting author response A pull request that is awaiting author's response label Feb 7, 2020
Fix reference URL

Co-Authored-By: Hirotaka Mizutani <[email protected]>
@mqtsuo02 mqtsuo02 requested a review from hirotaka February 7, 2020 02:42
@mqtsuo02 mqtsuo02 removed the status: awaiting author response A pull request that is awaiting author's response label Feb 7, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!LGTM 👍

@hirotaka hirotaka added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 7, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy merged commit 670ba63 into gatsbyjs:master Feb 7, 2020
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants