Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@JijiiMac
Copy link
Contributor

@JijiiMac JijiiMac commented Feb 5, 2020

概要

docs/add-seo-component を翻訳しました。

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

Ref: #1

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Feb 5, 2020
@smorimoto
Copy link
Contributor

Textlintエラーを修正してください。

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

読みやすい訳だと思います!
いくつか Textlint のエラーが出ているので、その改修と、Suggestion の確認をお願いします。

@Naturalclar Naturalclar added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 9, 2020
@JijiiMac JijiiMac force-pushed the docs/add-seo-component branch from f7d80e1 to 61d2043 Compare February 12, 2020 11:25
@JijiiMac
Copy link
Contributor Author

Sorry it took a while, よろしくおねがいします!

@JijiiMac JijiiMac added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 12, 2020
@smorimoto smorimoto added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 12, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

読みやすくて良い訳だと思います:+1:

@Naturalclar Naturalclar merged commit a58eca9 into gatsbyjs:master Feb 15, 2020
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants