Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@taka-take
Copy link
Contributor

概要

https://www.gatsbyjs.org/docs/add-a-manifest-file/ の日本語翻訳対応しました。
レビューのほどよろしくお願いします!

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

Ref: #1

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Feb 3, 2020
@taka-take taka-take changed the title Docs/add a manifest file Translate docs/add a manifest file Feb 4, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 5, 2020
不要な半角スペースを削除

Co-Authored-By: Yasuaki Uechi <[email protected]>
uetchy
uetchy previously approved these changes Feb 5, 2020
@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 5, 2020
@taka-take
Copy link
Contributor Author

レビューありがとうございます!
ご指摘の修正を反映しました。

Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!細かいのを1つだけSuggestionしたので、ご確認お願いいたします。

@hirotaka hirotaka added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Feb 6, 2020
@taka-take
Copy link
Contributor Author

レビューありがとうございます!
ご指摘の修正を反映しました。
たしかに1箇所だけだと違和感ありますね。

Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
LGTM 👍

@hirotaka hirotaka requested a review from uetchy February 6, 2020 12:35
@hirotaka hirotaka removed the status: awaiting author response A pull request that is awaiting author's response label Feb 6, 2020
@hirotaka hirotaka added the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Feb 6, 2020
@uetchy uetchy merged commit 5aea1d6 into gatsbyjs:master Feb 6, 2020
@taka-take taka-take deleted the docs/add-a-manifest-file branch February 11, 2020 04:57
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants