Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@nakajmg
Copy link
Contributor

@nakajmg nakajmg commented Feb 3, 2020

概要

https://www.gatsbyjs.org/docs/sourcing-from-graphcms/ の翻訳

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

補足

Getting content on the pageSummary が表現が難しく少々自信がないです。

Ref: #1

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Feb 3, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 8, 2020
@nakajmg nakajmg requested a review from uetchy February 12, 2020 22:00
@smorimoto smorimoto added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 12, 2020
uetchy
uetchy previously approved these changes Feb 13, 2020
@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 13, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!訳は全体的に良いと感じました!
細かいスペースの統一性のみ Suggest したので、ご確認お願いします:bow:

@nakajmg
Copy link
Contributor Author

nakajmg commented Feb 17, 2020

@Naturalclar
ありがとうございます!Suggestとりこみました 🙏

@smorimoto smorimoto added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 17, 2020
@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 19, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Naturalclar Naturalclar merged commit ccf353b into gatsbyjs:master Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants