Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Translate docs/telemetry #150

Merged
merged 6 commits into from
Feb 12, 2020
Merged

Translate docs/telemetry #150

merged 6 commits into from
Feb 12, 2020

Conversation

@bebetaro
Copy link
Contributor

@bebetaro bebetaro commented Feb 2, 2020

概要

I translated docs/telemetry page 😄
Original:https://www.gatsbyjs.org/docs/telemetry/
I appreciate to your review to my pull request 🙇
If I need to fix some points, please tell me about it. I will do it asap! Thanks!

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

Ref: #1

@uetchy uetchy added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Feb 3, 2020
@gatsbybot gatsbybot mentioned this pull request Feb 4, 2020
Closed
uetchy
uetchy reviewed Feb 8, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 8, 2020
@bebetaro
Copy link
Contributor Author

bebetaro commented Feb 11, 2020

@uetchy ご指摘の箇所について修正しました！ご確認をお願いします:bow:

@uetchy uetchy added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 11, 2020
uetchy
uetchy previously approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 12, 2020
hirotaka
hirotaka reviewed Feb 12, 2020
View reviewed changes
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！
改行に関してだけ Suggestion させていただいたのでご確認お願いいたします。

@hirotaka hirotaka added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Feb 12, 2020
@bebetaro
Copy link
Contributor Author

bebetaro commented Feb 12, 2020

@hirotaka ありがとうございます！ご指摘いただきました改行について修正しました！

hirotaka
hirotaka approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！
LGTM 👍

@hirotaka hirotaka requested a review from uetchy February 12, 2020 09:25
@hirotaka hirotaka added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 12, 2020
Naturalclar
Naturalclar approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Naturalclar Naturalclar merged commit 7e293bb into gatsbyjs:master Feb 12, 2020
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@smorimoto smorimoto Awaiting requested review from smorimoto

@uetchy uetchy Awaiting requested review from uetchy

2 more reviewers

@hirotaka hirotaka hirotaka approved these changes

@Naturalclar Naturalclar Naturalclar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bebetaro @hirotaka @uetchy @Naturalclar