Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

docs: translate tutorial/part-zero/index #15

Merged
merged 1 commit into from
Jan 14, 2020
Merged

docs: translate tutorial/part-zero/index #15

merged 1 commit into from
Jan 14, 2020

Conversation

@hirotaka
Copy link
Contributor

@hirotaka hirotaka commented Jan 14, 2020

No description provided.

uetchy
uetchy reviewed Jan 14, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
github-actions[bot]
github-actions bot reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
github-actions[bot]
github-actions bot reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
@hirotaka hirotaka requested a review from uetchy January 14, 2020 15:40
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
hirotaka
hirotaka commented Jan 14, 2020
View reviewed changes
github-actions[bot]
github-actions bot reviewed Jan 14, 2020
View reviewed changes
github-actions[bot]
github-actions bot reviewed Jan 14, 2020
View reviewed changes
github-actions[bot]
github-actions bot reviewed Jan 14, 2020
View reviewed changes
hirotaka
hirotaka commented Jan 14, 2020
View reviewed changes
hirotaka
hirotaka commented Jan 14, 2020
View reviewed changes
hirotaka
hirotaka commented Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
hirotaka
hirotaka commented Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

指摘がとても多くなってしまいましたが、全体的に読みやすく、レビューもやりやすいです！ありがとうございます！

hirotaka
hirotaka commented Jan 14, 2020
View reviewed changes
hirotaka
hirotaka commented Jan 14, 2020
View reviewed changes
@uetchy
Copy link
Contributor

uetchy commented Jan 14, 2020 •
edited
Loading

@hirotaka Suggestionをコミットする時、Files changedタブからAdd suggestion to batchを選ぶことで複数のSuggestionをまとめてコミット出来ます👍（コミット履歴が見やすくなる）

@hirotaka
Copy link
Contributor Author

hirotaka commented Jan 14, 2020

@hirotaka Suggestionをコミットする時、Files changedタブからAdd suggestion to batchを選ぶことで複数のSuggestionをまとめてコミット出来ます👍（コミット履歴が見やすくなる）

あ、そうだったんですね。。。次回からそうします！

uetchy
uetchy suggested changes Jan 14, 2020
View reviewed changes
uetchy
uetchy previously approved these changes Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 14, 2020
View reviewed changes
@uetchy
Copy link
Contributor

uetchy commented Jan 14, 2020

@hirotaka レビューが済んでマージする直前あたりで、大量のUpdate docs/tutorial/...コミットをすべて最初のdocs: translate tutorial/part-zero/indexコミットにsquashして良いと思います（僕や @Naturalclar さんのCo-author情報も残るので問題ないはず）

hirotaka
hirotaka commented Jan 14, 2020
View reviewed changes
@hirotaka
Copy link
Contributor Author

hirotaka commented Jan 14, 2020

@uetchy 了解です！squashしちゃいます。

uetchy
uetchy approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

Naturalclar
Naturalclar approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Naturalclar Naturalclar merged commit d4cbbab into master Jan 14, 2020
@Naturalclar Naturalclar deleted the tutorial/part-zero branch January 14, 2020 23:58
@hirotaka
Copy link
Contributor Author

hirotaka commented Jan 15, 2020

@Naturalclar @uetchy ありがとうございました！
これで大分慣れたので、次からはもう少しお手間を取らせないで進められるようにします。

@gatsbybot gatsbybot mentioned this pull request Jan 15, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@uetchy uetchy uetchy approved these changes

@Naturalclar Naturalclar Naturalclar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core pages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hirotaka @uetchy @Naturalclar