This repository was archived by the owner on Jan 20, 2025. It is now read-only.
Translate docs/add-offline-support-with-a-service-worker #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkt989
requested review from
Naturalclar,
hirotaka,
smorimoto and
uetchy
as code owners
tkt989
changed the title
tkt989
changed the title
smorimoto
added
the
status: awaiting review
hirotaka
added
status: awaiting more approval
smorimoto
reviewed
Feb 6, 2020
Comment on lines
83
to
84
| - [Service Worker の紹介](https://developers.google.com/web/fundamentals/primers/service-workers/?hl=ja) | ||
| - [サービスワーカー API](https://developer.mozilla.org/ja/docs/Web/API/Service_Worker_API) |
Contributor
There was a problem hiding this comment.
Service Workerなのか、サービスワーカーなのか統一したいと思ったりしました。 CC: @uetchy @Naturalclar @hirotaka
Contributor
There was a problem hiding this comment.
リンク先のMozillaのドキュメントのタイトルがサービスワーカーAPIで、本文内ではService Workerになっていたので、このままでいいのかなと思ったのですが、統一したいですよね。
https://developer.mozilla.org/ja/docs/Web/API/Service_Worker_API
Webの仕様の名称なので、Service Workerのままがいいかなと思うのですが、いかがでしょうか？ @uetchy @Naturalclar
Contributor
There was a problem hiding this comment.
基本的に記事のタイトルに準じますが、これは規格名なのでService Workerのほうが良いと思います。
Contributor
Author
There was a problem hiding this comment.
確かに規格名ですので、そのまま書いたほうがいいですね。修正します。
以前、担当したページにも同じリンクがあったので、そちらの方も修正してPRしますね。
#128
smorimoto
reviewed
Feb 6, 2020
Co-Authored-By: BSKY <[email protected]>
hirotaka
approved these changes
Feb 7, 2020
uetchy
approved these changes
Feb 7, 2020
uetchy
removed
the
status: awaiting more approval
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
docs/add-offline-support-with-a-serviceを翻訳しました。レビューよろしくお願いします:bow:
チェックリスト
textlintを使って校正を行いました。Allow edits from maintainersにチェックを入れました。補足
Ref: #1