Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@kenchon
Copy link
Contributor

@kenchon kenchon commented Jan 28, 2020

概要

  • docs/theme-api.mdの翻訳

よろしくお願いします 🙇

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

Ref: #1

Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常に読みやすい翻訳です👍

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 28, 2020
@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 28, 2020
@kenchon
Copy link
Contributor Author

kenchon commented Jan 28, 2020

@uetchy レビュー&サジェストありがとうございます 😄 反映しました

uetchy
uetchy previously approved these changes Jan 28, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 28, 2020
@smorimoto smorimoto added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 28, 2020
@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 29, 2020
uetchy
uetchy previously approved these changes Jan 29, 2020
@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 29, 2020
@kenchon kenchon changed the title Docs/theme api Translate docs/theme api Jan 29, 2020
@kenchon kenchon changed the title Translate docs/theme api Translate docs/theme-api Jan 29, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全体的に良いと思います!細かい箇所だけ Suggest したので確認お願いします!

@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 31, 2020
kenchon and others added 4 commits January 31, 2020 17:58
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
Co-Authored-By: Jesse Katsumata <[email protected]>
@kenchon
Copy link
Contributor Author

kenchon commented Jan 31, 2020

@Naturalclar サジェストありがとうございます!参考になりましたm(_ _)m 反映しました。

@uetchy uetchy added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 1, 2020
@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 1, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ありがとうございます!

@Naturalclar Naturalclar merged commit a902167 into gatsbyjs:master Feb 1, 2020
@gatsbot
Copy link

gatsbot bot commented Feb 1, 2020

Holy buckets, @kenmikanmi — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants