This repository was archived by the owner on Jan 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 113
translate docs/deploying-s3-cloudfront #135
Merged
uetchy
merged 2 commits into
gatsbyjs:master
from
Imamachi-n:docs/deploying-to-s3-cloudfront
Jan 29, 2020
Merged
translate docs/deploying-s3-cloudfront #135
uetchy
merged 2 commits into
gatsbyjs:master
from
Imamachi-n:docs/deploying-to-s3-cloudfront
Jan 29, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uetchy
previously approved these changes
Jan 28, 2020
Contributor
uetchy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
非常に読みやすいです👍
hirotaka
reviewed
Jan 28, 2020
Contributor
hirotaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!非常に読みやすいです。
ちょっと一箇所だけひっかかった感じがしたので、ご確認いただけますでしょうか。
Co-Authored-By: Hirotaka Mizutani <[email protected]>
Contributor
Author
|
レビューありがとうございました! |
hirotaka
approved these changes
Jan 29, 2020
Contributor
hirotaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!LGTM 👍
uetchy
approved these changes
Jan 29, 2020
Contributor
uetchy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
docs/deploying-to-s3-cloudfrontを翻訳しました。お手数ですが、内容の確認をよろしくお願いします。
チェックリスト
textlintを使って校正を行いました。Allow edits from maintainersにチェックを入れました。補足
Ref: #1