Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@uetchy
Copy link
Contributor

@uetchy uetchy commented Jan 14, 2020

  • style-guideを翻訳
  • JTF翻訳ガイドの「カタカナ語末尾の長音符は基本的に省略しない」を追加

@uetchy uetchy force-pushed the style-guide branch 2 times, most recently from 073ed83 to 3219ac1 Compare January 14, 2020 11:19
@uetchy uetchy marked this pull request as ready for review January 14, 2020 11:48
hirotaka
hirotaka previously approved these changes Jan 14, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

importar Reaccionar desde "reaccionar"
exportar defecto () => (
   <div estilo = {{color: `morado`, fontSize:` 72px`}}> ¡Hola Gatsby! </div>
インポート リアクト フロム "リアクト"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここ笑う


### `npm run lint`

`npm run lint`を実行して、ローカルで textlint による校正を受けることができます。ほとんどのエラーは`npm run format`を実行することで自動修正できます。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Naturalclar
Naturalclar previously approved these changes Jan 14, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@uetchy uetchy requested a review from hirotaka January 14, 2020 15:19
@smorimoto
Copy link
Contributor

@Naturalclar @hirotaka Conflict resolved, please review again and approve if there is no problem.

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@uetchy uetchy merged commit e249367 into master Jan 14, 2020
@uetchy uetchy deleted the style-guide branch January 14, 2020 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants