Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@yukisato
Copy link
Contributor

@yukisato yukisato commented Jan 25, 2020

概要

記事全体の翻訳を行いました。
レビューをお願いします!

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

Ref: #1

@uetchy
Copy link
Contributor

uetchy commented Jan 25, 2020

@yukisato diffに表示されているtextlintエラーを修正してください👍

@uetchy uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 25, 2020
@yukisato
Copy link
Contributor Author

@uetchy すみません!再度、最新の状態でtextlintが通るようにしました!
よろしくお願いします。

@yukisato yukisato added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 25, 2020
uetchy
uetchy previously approved these changes Jan 28, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

読みやすい翻訳です👍

@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 28, 2020
@yukisato yukisato added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 29, 2020
uetchy
uetchy previously approved these changes Jan 29, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄‍♂️

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 29, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!いくつかSuggestionさせていただいたのでご確認お願いいたします。

@hirotaka hirotaka added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 31, 2020
@yukisato
Copy link
Contributor Author

yukisato commented Feb 4, 2020

@Naturalclar @imbsky レビューありがとうございました!
Suggestについて取り込ませて頂きましたので、よろしくお願い致します。

@yukisato yukisato added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 4, 2020
@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 4, 2020
@smorimoto smorimoto requested a review from Naturalclar February 6, 2020 08:20
@smorimoto smorimoto added the status: ready to merge A pull request that can be merged once CI is green label Feb 6, 2020
hirotaka
hirotaka approved these changes Feb 6, 2020
@uetchy
Copy link
Contributor

uetchy commented Feb 6, 2020

@Naturalclar 再レビューお願いします

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビュー遅れて申し訳ありません! LGTM です!

@Naturalclar Naturalclar merged commit a1d3b5c into gatsbyjs:master Feb 8, 2020
@yukisato yukisato deleted the tutorial/wordpress-source-plugin-tutorial branch February 8, 2020 19:13
@uetchy uetchy removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned status: ready to merge A pull request that can be merged once CI is green labels Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants