Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@nzws
Copy link
Contributor

@nzws nzws commented Jan 20, 2020

概要

docs/sourcing-content-from-json-or-yaml を翻訳しました。よろしくお願いいたします。

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました(推奨)
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数が足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 20, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ありがとうございます!翻訳は読みやすいと思いました!いくつか Suggest したのでご確認お願いします。

@uetchy uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 27, 2020
@nzws nzws dismissed stale reviews from uetchy and Naturalclar via 6d5714b January 27, 2020 06:09
@nzws
Copy link
Contributor Author

nzws commented Jan 27, 2020

マージしました🙇

@nzws nzws requested review from Naturalclar and uetchy January 27, 2020 06:09
uetchy
uetchy previously approved these changes Jan 27, 2020
@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 27, 2020
@smorimoto smorimoto added status: awaiting author response A pull request that is awaiting author's response status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Feb 2, 2020
@smorimoto smorimoto added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned status: ready to merge A pull request that can be merged once CI is green and removed status: awaiting author response A pull request that is awaiting author's response status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 2, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ありがとうございます!

@Naturalclar Naturalclar merged commit da69223 into gatsbyjs:master Feb 3, 2020
@uetchy uetchy removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned status: ready to merge A pull request that can be merged once CI is green labels Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants