Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Translate docs/tutorial-part-four #110

Merged
merged 5 commits into from
Jan 23, 2020
Merged

Translate docs/tutorial-part-four #110

merged 5 commits into from
Jan 23, 2020

Conversation

@yuuyu00
Copy link
Contributor

@yuuyu00 yuuyu00 commented Jan 20, 2020

概要

チュートリアルの4章を翻訳しました。

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました（推奨）
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数が足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 20, 2020
@gatsbybot gatsbybot mentioned this pull request Jan 21, 2020
Closed
Naturalclar
Naturalclar reviewed Jan 21, 2020
View reviewed changes
docs/tutorial/part-four/index.md Outdated

Welcome to Part Four of the tutorial! Halfway through! Hope things are starting
to feel pretty comfortable 😀
チュートリアルの第 4 章へようこそ！　まだ道半ばです！　 Gatsby を快適に感じ始められることを願っています。
Copy link
Contributor

@Naturalclar Naturalclar Jan 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全角スペースが入ってそう？
lint ruleで全角スペース弾く様にしたいな

Suggested change
チュートリアルの第 4 章へようこそ！　まだ道半ばです！　 Gatsby を快適に感じ始められることを願っています。
チュートリアルの第 4 章へようこそ！まだ道半ばです！ Gatsby を快適に感じ始められることを願っています。

Copy link
Contributor

@uetchy uetchy Jan 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prhでチェックできそう。

！と日本語の間はスペース自体無くても良いかも。

Copy link
Contributor Author

@yuuyu00 yuuyu00 Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

エクスクラメーションマークの後に連続して文字が入る場合全角スペースを入れるようにコミット時のlintで言われた気がします、一旦消してもう一度確認してみます🙏

Copy link
Contributor Author

@yuuyu00 yuuyu00 Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

申し訳ありません、勘違いでした！修正しましたのでご確認お願いします🙇‍♂️

Naturalclar
Naturalclar reviewed Jan 21, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 21, 2020
View reviewed changes
@smorimoto
Copy link
Contributor

smorimoto commented Jan 21, 2020

Allow edits from maintainersにチェック入ってなさそう？

Naturalclar
Naturalclar reviewed Jan 21, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 21, 2020
View reviewed changes
@yuuyu00
Copy link
Contributor Author

yuuyu00 commented Jan 21, 2020

Allow edits from maintainersにチェック入ってなさそう？

Allow edits from maintainersへのチェックは入っているように見えます👀
スクリーンショット 2020-01-21 18 48 56

@smorimoto
Copy link
Contributor

smorimoto commented Jan 21, 2020

であれば You do not have permission to push to this repository. になるのは権限周りの設定の問題っぽいですね…

Naturalclar
Naturalclar reviewed Jan 21, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 21, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 21, 2020
View reviewed changes
@uetchy uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 22, 2020
@yuuyu00
Copy link
Contributor Author

yuuyu00 commented Jan 22, 2020

Suggestionsを反映しました。

uetchy
uetchy previously approved these changes Jan 22, 2020
View reviewed changes
@uetchy uetchy removed the status: awaiting author response A pull request that is awaiting author's response label Jan 22, 2020
Naturalclar
Naturalclar reviewed Jan 22, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 22, 2020
View reviewed changes
@yuuyu00 yuuyu00 dismissed stale reviews from uetchy via 0ddaa7d January 22, 2020 10:11
@yuuyu00 yuuyu00 requested review from Naturalclar and uetchy January 22, 2020 10:53
Naturalclar
Naturalclar reviewed Jan 22, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 22, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 22, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 22, 2020
View reviewed changes
Naturalclar
Naturalclar reviewed Jan 22, 2020
View reviewed changes
Naturalclar
Naturalclar suggested changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻訳の内容は良さそうです！細かいスペースだけ統一させたいので確認おねがいします。

Naturalclar
Naturalclar approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ありがとうございます！

@Naturalclar Naturalclar added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 22, 2020
uetchy
uetchy approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy merged commit 025d670 into gatsbyjs:master Jan 23, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 23, 2020

Holy buckets, @yuuyu00 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@uetchy uetchy added core pages and removed core pages status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hirotaka hirotaka Awaiting requested review from hirotaka

@smorimoto smorimoto Awaiting requested review from smorimoto

2 more reviewers

@uetchy uetchy uetchy approved these changes

@Naturalclar Naturalclar Naturalclar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core pages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yuuyu00 @smorimoto @uetchy @Naturalclar