Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@JijiiMac
Copy link
Contributor

@JijiiMac JijiiMac commented Jan 20, 2020

概要

docs/themes/what-are-gatsby-themes を翻訳しました。

最後の関連ページ・ブログへのリンクに関しては、

  • ページは将来的に翻訳されることを考慮し仮の日本語タイトルを用意
  • ブログは当分はなさそうと考え英語のまま
    にしました。

レビューお願いいたします。

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました(推奨)
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数が足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 20, 2020
@JijiiMac JijiiMac force-pushed the docs/themes/what-are-gatsby-themes branch from c41c602 to bb7f91b Compare January 22, 2020 11:36
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます👍

@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 26, 2020
Co-Authored-By: Yasuaki Uechi <[email protected]>
@JijiiMac
Copy link
Contributor Author

レビューありがとうございます、指摘点反映させていただきました

@JijiiMac JijiiMac added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 27, 2020
@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 27, 2020
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!非常にわかりやすかったです。
LGTM 👍

@hirotaka hirotaka merged commit c685eb0 into gatsbyjs:master Jan 28, 2020
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants