This repository was archived by the owner on Jan 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 113
translated docs/testing-react-components.md #102
Merged
Naturalclar
merged 2 commits into
gatsbyjs:master
from
Imamachi-n:docs/testing-react-components
Jan 27, 2020
Merged
translated docs/testing-react-components.md #102
Naturalclar
merged 2 commits into
gatsbyjs:master
from
Imamachi-n:docs/testing-react-components
Jan 27, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uetchy
previously approved these changes
Jan 26, 2020
| --- | ||
|
|
||
| _The recommended testing framework is [Jest](https://jestjs.io/). This guide assumes that you followed the [Unit testing](/docs/unit-testing) guide to setup Jest._ | ||
| _推奨されるテスティングフレームワークは [Jest](https://jestjs.io/) です。このガイドでは、[ユニットテスト](/docs/unit-testing)のガイドに従って Jest がセットアップ済みであることを前提としています。_ |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| _推奨されるテスティングフレームワークは [Jest](https://jestjs.io/) です。このガイドでは、[ユニットテスト](/docs/unit-testing)のガイドに従って Jest がセットアップ済みであることを前提としています。_ | |
| _推奨されるテストフレームワークは [Jest](https://jestjs.io/) です。このガイドでは、[ユニットテスト](/docs/unit-testing)のガイドに従って Jest がセットアップ済みであることを前提としています。_ |
Imamachi-n
commented
Jan 27, 2020
Contributor
Author
Imamachi-n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
レビューありがとうございます。
変更を反映させていただきました!
uetchy
approved these changes
Jan 27, 2020
Contributor
uetchy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Naturalclar
approved these changes
Jan 27, 2020
Contributor
Naturalclar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
docs/testing-react-componentsの翻訳になります。お手数ですが、レビューをお願い致します。
原文ページ:
https://www.gatsbyjs.org/docs/testing-react-components/
チェックリスト
textlintを使って校正を行いました(推奨)Allow edits from maintainersにチェックを入れました。しばらく待ってもレビューが終わらなかったり、必要なレビュー数が足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。