This repository was archived by the owner on Feb 9, 2020. It is now read-only.
update for 0.11 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
updated and builds correctly 🍡 |
garyb
reviewed
Apr 13, 2017
Owner
garyb
left a comment
garyb
left a comment
There was a problem hiding this comment.
All looks great apart from auto-wrapping QS!
src/DOM/Classy/ParentNode.purs
Outdated
| -- | null if no such element exists. | ||
| querySelector :: forall n eff. IsParentNode n => String -> n -> Eff (dom :: DOM | eff) (Nullable N.Element) | ||
| querySelector selector = PN.querySelector selector <<< toParentNode | ||
| querySelector :: forall n eff. IsParentNode n => String -> n -> Eff (dom :: DOM | eff) (Maybe N.Element) |
Owner
There was a problem hiding this comment.
Can we update the argument to use QuerySelector rather than String here (and below)?
Contributor
Author
There was a problem hiding this comment.
ah, yeah, might as well. pushed it up
justinwoo
force-pushed
the
0.11
branch
2 times, most recently
from
37afe85 to
8dc7292
Compare
garyb
reviewed
Apr 13, 2017
src/DOM/Classy/ParentNode.purs
Outdated
| import DOM (DOM) | ||
| import DOM.Classy.Util (fromAny) | ||
| import DOM.Node.ParentNode (QuerySelector) | ||
| import Data.Maybe (Maybe) |
Owner
There was a problem hiding this comment.
Sorry, last one, can we un-psc-ide the import ordering? 😉
Contributor
Author
There was a problem hiding this comment.
hah, all right, pushed it up. i forgot letting psc-ide import stuff jumbles up the imports.
Contributor
Author
|
also got rid of the single import for queryselector |
Owner
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on purescript-deprecated/purescript-dom#89