Skip to content

Conversation

lishaduck
Copy link
Contributor

So we hit microsoft/TypeScript#46011 last time (and tsdown bugs which are now fixed).

@brettz9
Copy link
Collaborator

brettz9 commented Aug 11, 2025

Looks great... Just it seems that /dist/iterateJsdoc.cjs does not use module.exports for its default export. The other public exports LGTM...

@brettz9
Copy link
Collaborator

brettz9 commented Aug 11, 2025

If there's no way around it, I guess we can just add it as a breaking change that .default will now be required with that file, but just would be nice to fix if possible.

@lishaduck
Copy link
Contributor Author

Looks great... Just it seems that /dist/iterateJsdoc.cjs does not use module.exports for its default export. The other public exports LGTM...

It doesn't currently either, so I think that's fine?

@brettz9 brettz9 merged commit b19f6f9 into gajus:main Aug 11, 2025
4 checks passed
Copy link

🎉 This PR is included in version 53.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lishaduck lishaduck deleted the rebuild branch August 11, 2025 18:49
brettz9 added a commit to brettz9/eslint-plugin-jsdoc that referenced this pull request Aug 13, 2025
BREAKING CHANGE:

tsdown fix still not working properly, so reverting.

This reverts commit b19f6f9.
brettz9 added a commit that referenced this pull request Aug 13, 2025
BREAKING CHANGE:

tsdown fix still not working properly, so reverting.

This reverts commit b19f6f9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants