Refactor gradleHome to check for GRADLE_USER_HOME first #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle users can specify where gradle lives via
$GRADLE_USER_HOME. When this is done, the classpath resolver doesn't check the location set by the env var, but only the default location. This results in a failed build if kotlin is not on$PATH.This PR fixes that by checking for
$GRADLE_USER_HOMEfirst, and falling back to the default~/.gradleif it's not set.To see the change in action, open the base repo in gitpod and run
./gradlew :server:build. It should fail.To see the fix in action, open this repo in gitpod and run
./gradlew :server:build. It should succeed.This closes #254