Fix an issue when trying to resolve an non source file #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that in some cases the plugin is trying to resolve files who are not part of the workspace, due to either their temporary nature, or other IDE or tool file. In my case, it was trying to resole files from the vim .undodir directory, was failing to parse those files due to their binary nature, and the whole sourceset resolution was failing in consequence. To avoid that issue add a try catch around the file reading method to ensure exception are not fired, and the resolution does not break.
Owner
|
@shoebox Thank you for your contribution! I have left some notes below. |
fwcd
reviewed
Mar 28, 2019
fwcd
reviewed
Mar 28, 2019
| var content = "" | ||
|
|
||
| try { | ||
| content = Files.readAllLines(file).joinToString("\n") |
There was a problem hiding this comment.
It will be cleaner if you return from this line instead of saving the file contents to a variable
Owner
There was a problem hiding this comment.
Storing the contents in a variable is fine IMO. Since the string is going to be wrapped into a SourceVersion anyway, having two returns would entail some code duplication.
Raise the level of verbosing level in case of an exception while parsing a source set file to `warn`.
Catch only IOException for now, being the issue we are encountering now. That try/catch block can be removed, when the `.gitignore` file content is taken into account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in some cases the plugin is trying to resolve files who
are not part of the workspace, due to either their temporary nature, or
other IDE or tool file.
In my case, it was trying to resole files from the vim .undodir
directory, was failing to parse those files due to their binary nature,
and the whole sourceset resolution was failing in consequence.
To avoid that issue add a try catch around the file reading method to
ensure exception are not fired, and the resolution does not break.