-
-
Notifications
You must be signed in to change notification settings - Fork 50
Reflection fixes #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflection fixes #53
Conversation
Well, technically, not all of them. I can't fix one in |
src/buddy/core/crypto.clj
Outdated
|
||
(def ^:no-doc | ||
+block-cipher-engines+ | ||
^BlockCipher +block-cipher-engines+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this type hint is wrong, because +block-cipher-engines+
is a hash-map and not a BlockCipher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
src/buddy/core/crypto.clj
Outdated
|
||
(def ^:no-doc | ||
+cipher-modes+ | ||
^BlockCipher +cipher-modes+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
I'm slightly worried about the |
@niwinz It seems legit for me. Just tested the changes and checked them all. It seems that it's working just fine |
Hi - 👋 - we've adopted These reflection warnings bubble up into our tools, so I dove in to investigate and fix them up and then found this excellent branch. Is there any interest in trying to merge this branch, or one like it but cleanly rebased off current master? I'd be happy to do the work. |
Just merged master and all was fine. Travis appears to have built cleanly (https://travis-ci.org/github/funcool/buddy-core/builds/680771704) but something is wrong with the feedback to this PR. |
Cool - great work. I completely understand being careful about changes to this particular piece of machinery. We are here and have some spare cycles if there's anything we can do to push this forward - let me know. |
Finally merged! thanks! |
Nice! Thanks, yous. 👏 🙇 |
I note there are now other warnings as the set of checked items are out of date. Also, it's a warning, not an error so it doesn't fail the build, so harder due people to notice the issue. |
This is what I see now, are you seeing the same?
|
Hadn't re-run it locally, was just looking at the Travis builds e.g https://travis-ci.org/github/funcool/buddy-core/jobs/747388146 but that looks about the same, plus some issues in the tests. |
This PR enables "*warn-on-reflection*" and fixes all the reflection warnings I found as a result. I've run the test suite locally, and haven't hit any issues, but there could potentially still be regression issues if someone's calling something with a class I haven't hit during my testing.