Update part12c.md #4084
Open
Update part12c.md #4084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using both nginx:1.25-alpine and nginx:1.20.1. Better to update to nginx:1.25-alpine
ziirou
suggested changes
Sep 4, 2025
There was a problem hiding this comment.
Maybe update the version/image to the container list too.
$ docker container ls
CONTAINER ID IMAGE COMMAND PORTS NAMES
a02ae58f3e8d nginx:1.25-alpine ... 0.0.0.0:8080->80/tcp reverse-proxy
5ee0284566b4 hello-front-dev ... 0.0.0.0:5173->5173/tcp hello-front-devEDIT: I opened my PR again as there were more nginx:1.20.1 used and found out that bash is not included in Alpine-based images.
|
I'm not sure why 2 diff versions are being used. As a novice, it's a bit confusing. If 1.20.1 is being used during development for better compatibility, some text needs to be added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using both nginx:1.25-alpine and nginx:1.20.1. Better to update to nginx:1.25-alpine