Add warning about json modules to en/part9c #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a topic to warn student about pitfalls of requiring modules with the same filename but different extensions
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing exercise 9.16 I ran into a problem extending a typescript interface with a new property.
I had a flat directory "data" with contents:
├── patients.json
└── patients.ts
and tried to import the patients.ts file but I hadn't realized earlier that because I set resolveJsonModule to true in tsconfig.json, patients.json would now be included in node module resolution.
So while trying to:
import patients from "./data/patients"Typescript kept compiling the patients.json file instead of patients.ts so my new object with supposed new properties was using stale data from the .json file and with type assertions it was difficult to track down the exact problem.
I made an edit to the English version of part9c that includes a warning about this behavior.