Fix support for symbolic links in LocalFileSystem
#608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yes, I think this is fine. You are right that it probably best to keep close to what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #591
info['type'] = 'link'for symbolic links,LocalFileSystem.infoactually breaks more than justisdir, e.g.isfile,walketc. are all affected too.LocalFileSystem.info['type']to follow symlinks correctly and always give eitherdirectoryorfile.LocalFileSystem.info['islink']flag to enable checking for links without breaking the rest.Let me know if this fix is acceptable, happy to implement an alternative if preferred 😃