Remove deprecated utcnow and utcfromtimestamp #1314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1312.
This replaces the functions
datetime.utcnowanddatetime.utcfromtimestampwhich are deprecated in Python 3.12. Following the CPython issue (python/cpython#103857) and related article (https://blog.ganssle.io/articles/2019/11/utcnow.html) they are replaced as follows:datetime.utcnow()->datetime.now(tz=timezone.utc)anddatetime.utcfromtimestamp(x)->datetime.fromtimestamp(x, tz=timezone.utc)The following example
used to give
whereas after this PR it gives
so previously datetimes returned by
fsspecwere timezone-naive whereas now they are timezone aware at UTC. This is more correct than it used to be as suchcreateddatetimes are derived from UNIX timestamps which are seconds since the epoch at UTC so it is correct to label them as UTC (as in the article linked above) rather than as timezone naive. But some users/libraries may be making assumptions about the timezone which are no longer true.It would be possible to change this PR to drop the UTC timezone to make such datetimes timezone-naive, which more closely follows the old behaviour but is less correct in the long term, so I prefer the solution here.