Consolidate records part two #2766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-degraw
approved these changes
Feb 8, 2023
Contributor
josh-degraw
left a comment
josh-degraw
left a comment
There was a problem hiding this comment.
Looks awesome! I just noticed one small thing in a doc comment but other than that LGTM
Contributor
Author
|
I'm going to wait for dotnet/fsharp#14723. |
Contributor
Author
|
@josh-degraw would you mind taking another look at this? |
josh-degraw
approved these changes
Feb 11, 2023
nojaf
added a commit
that referenced
this pull request
Feb 22, 2023
* Remove genCrampedFields inside genMultilineRecord. * Remove ExprAnonRecordNode for now. * Expr.AnonStructRecord!
nojaf
added a commit
that referenced
this pull request
Mar 17, 2023
* Remove genCrampedFields inside genMultilineRecord. * Remove ExprAnonRecordNode for now. * Expr.AnonStructRecord!
nojaf
added a commit
that referenced
this pull request
Mar 27, 2023
* Remove genCrampedFields inside genMultilineRecord. * Remove ExprAnonRecordNode for now. * Expr.AnonStructRecord!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #2750.
I changed some of the tests as I believe the outcome is correct.
Indentation should take place from the opening brace position, I remember Don saying that fondly at some point.
At some point, I will correct the range of
SynExpr.AnonRecdto start from thestructkeyword.Then we can bring back
ExprAnonRecordNodeand properly insertSingleTextNodeforstruct.