Prefer IDisposable over IAsyncDisposable for disposing ReaderWriterLock
#227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
changed the title
IDisposable over IAsyndDisposable for disposing ReaderWriterLockIDisposable over IAsyncDisposable for disposing ReaderWriterLock
Member
Author
|
Based on earlier comments/discussion this can be merged. |
Closed
abelbraaksma
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title. This does not fix any bug, but is just a small improvement. No need to
IAsyncDisposablefor internal stuff when there's clearly no async code involved in the disposing of resources (in this case,ReaderWriterLock).