Skip to content

avoid cloning in bencher #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2024
Merged

avoid cloning in bencher #67

merged 2 commits into from
Dec 2, 2024

Conversation

asibahi
Copy link
Contributor

@asibahi asibahi commented Dec 2, 2024

Use Copy bound instead of Clone. As references are Copy.

@asibahi
Update runner.rs
83ab2d7 
Use `Copy` bound instead of `Clone`. As references are `Copy`.
mjclarke94
mjclarke94 reviewed Dec 2, 2024
View reviewed changes
@fspoettel fspoettel merged commit a50047a into fspoettel:main Dec 2, 2024
@fspoettel
Copy link
Owner

thank you very much @asibahi & @mjclarke94 ! 🙌

@asibahi asibahi deleted the copy-vs-clone branch December 3, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mjclarke94 mjclarke94 mjclarke94 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asibahi @fspoettel @mjclarke94