Skip to content

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Nov 10, 2014

Based on #258, I added some documentation about FSharp.Core.dll

fsgit added a commit that referenced this pull request Nov 10, 2014
Documentation about referencing and/or including FSharp.Core.dll
@fsgit fsgit merged commit 98b1f07 into fsharp:master Nov 10, 2014
@adamkennedy
Copy link

Based on this documentation, I'm going to do some investigation and see which situation applies to my case and how I ended up this way. I might pull in a colleague of mine as well.

I'm quite surprised I could end up blowing up this way with a default setup (typical F# SDK install, vanilla F# project in Visual Studio, and the production FSharp.Compiler.Service NuGet package.

@adamkennedy
Copy link

A couple of comments on following the documentation.

"HostedCompiler.exe" wasn't immediately clear (though it was by the end of the reading). Perhaps "YourHostedCompiler.exe" ?

Second, after configuring the hosted compiler project to make use of the "FSharp.Core for F# 3.1, Microsoft signed" I had some clashes with FSharp.Core when building, because the default setup of other F# projects in the same solution were linking to the system FSharp.Core library.

It might be worth adding a note to change the FSharp.Core references of other projects in the same solution to match (library projects, test projects etc)

@dsyme
Copy link
Contributor Author

dsyme commented Nov 11, 2014

Could you send two pull requests for these if possible? thanks

Edit here: https://github.com/fsharp/FSharp.Compiler.Service/blob/master/docs/content/corelib.fsx

dsyme pushed a commit to dsyme/FSharp.Compiler.Service that referenced this pull request Mar 23, 2015
closes fsharp#260

commit c272c8d5762ea2b83ef720bf5531ab391adda29f
Author: Anh-Dung Phan <[email protected]>
Date:   Tue Feb 24 11:46:09 2015 +0000

    Remove unused stuff

commit aba396add02cd15433654270e5d3526aee757c47
Author: Anh-Dung Phan <[email protected]>
Date:   Sat Feb 21 12:49:11 2015 +0000

    Fix a mistake in inactive code

commit c77e6f46a75462313c5cae0ae3bf8e03192418d9
Author: Anh-Dung Phan <[email protected]>
Date:   Sat Feb 21 12:42:13 2015 +0000

    Remove 'Execute Line in F# Interactive' command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants