Skip to content

Fix return value of set_weather_regulated_charge(enable=True) #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix return value of set_weather_regulated_charge(enable=True) #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 16 additions & 35 deletions e3dc/_e3dc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2397,39 +2397,20 @@ def set_weather_regulated_charge(self, enable: bool, keepAlive: bool = False):
0 if success
-1 if error
"""
if enable:
res = self.sendRequest(
(
RscpTag.EMS_REQ_SET_POWER_SETTINGS,
RscpType.Container,
[
(
RscpTag.EMS_WEATHER_REGULATED_CHARGE_ENABLED,
RscpType.UChar8,
1,
)
],
),
keepAlive=keepAlive,
)
else:
res = self.sendRequest(
(
RscpTag.EMS_REQ_SET_POWER_SETTINGS,
RscpType.Container,
[
(
RscpTag.EMS_WEATHER_REGULATED_CHARGE_ENABLED,
RscpType.UChar8,
0,
)
],
),
keepAlive=keepAlive,
)
res = self.sendRequest(
(
RscpTag.EMS_REQ_SET_POWER_SETTINGS,
RscpType.Container,
[
(
RscpTag.EMS_WEATHER_REGULATED_CHARGE_ENABLED,
RscpType.UChar8,
enable,
)
],
),
keepAlive=keepAlive,
)

# validate return code for EMS_RES_WEATHER_REGULATED_CHARGE_ENABLED is 0
if res[2][0][2] == 0:
return 0
else:
return -1
# validate return code for EMS_RES_WEATHER_REGULATED_CHARGE_ENABLED being equal to requested new state
return res[2][0][2] == enable